Skip to content

Feature/379 385 list default layout#390

Open
carbontwelve wants to merge 18 commits into
release/2025from
feature/379-385-list-default-layout
Open

Feature/379 385 list default layout#390
carbontwelve wants to merge 18 commits into
release/2025from
feature/379-385-list-default-layout

Conversation

@carbontwelve

Copy link
Copy Markdown
Contributor

No description provided.

... have updated #379 because I noticed that page-index.njk and page-list.njk are duplicate functionality and may be merged.
... pulled out debug.njk into own component because I will be using this to debug merging of page-index.njk with page-list.njk in future commits.
... this stops us from having issues with Nunjucks and async promise resolving within templates.

Instead of the template waiting for the result of the filter function, the function instead returns what the image src will be and enqueues processing the screenshot which will happen during the `eleventy.after` lifecycle hook.
... 11ty processes global data files found in the `_data` directory first, which makes the data available to collections. Not sure *why* I was loading it via the 11tydata but it meant that for books the lists template was unable to count how many items it contained.

With this change it can now.
…out' into feature/379-385-list-default-layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant